Able to set custom AWS S3 settings for coverband #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will address this in a quick follow up after getting 2.0 released... PR for Coverband 2.0! Alpha release running on prod for last 2 months. Let me know if there is any last minute feedback, if not I will release later tonight ;) Also, sharing thoughts Future 3.0 roadmap. |
|
For now, we are using 1.5.4 with this PR. So it would be great to include this into 2.0 ... |
|
OK, this is merged into the 2.0 line, on the master branch. I am going to handle some of the other PRs and get a 2.x.x out in a few days, which will include this work. Thanks @a0s |
|
this is in the 2.0.1 release https://github.com/danmayer/coverband/blob/master/changes.md#201 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for separate AWS S3 settings of region/bucket/key/secret for coverband in case when we don't want to use default AWS_ACCESS_KEY_ID/AWS_SECRET_ACCESS_KEY.
Old behaviour, reading from AWS_ACCESS_KEY_ID/AWS_SECRET_ACCESS_KEY:
New behaviour, set all settings for coverband only: